Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #4898

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Update README.md #4898

merged 2 commits into from
Sep 28, 2022

Conversation

stijlmassi
Copy link
Contributor

In the astro.config.mjs: defineConfig() was missing.

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@stijlmassi
Update README.md
becbe89 
In the astro.config.mjs: defineConfig() was missing.
@stijlmassi stijlmassi requested a review from a team as a code owner September 28, 2022 10:17
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f572534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 28, 2022
yanthomasdev
yanthomasdev reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @stijlmassi, thanks! This sample is also missing the defineConfig import, so I added it as a suggestion.

packages/integrations/tailwind/README.md Show resolved Hide resolved
@FredKSchott
Copy link
Member

LGTM!

@yanthomasdev yanthomasdev merged commit 9103ac5 into withastro:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stijlmassi @FredKSchott @yanthomasdev