Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes client:only CSS in Svelte components #4782

Merged
merged 2 commits into from
Sep 17, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 16, 2022

Changes

Testing

  • This should have been covered by an existing test, but because we were testing multiple things in a single page it was accidentally passing.
  • Moved to a standalone page to ensure that we are testing this and only this in a single test case.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: e8f4d68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 16, 2022
Copy link

@zachlankton zachlankton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in my project and it fixes the problem! Thanks!

@matthewp matthewp merged commit 8f9463e into main Sep 17, 2022
@matthewp matthewp deleted the client-only-svelte-css branch September 17, 2022 16:32
@astrobot-houston astrobot-houston mentioned this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte styles not included in build for client:only components
3 participants