Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@astrojs/image] Fixes a regression in remote image filenames #4649

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

tony-sull
Copy link
Contributor

Closes #4644

Changes

  • Fixes a regression in filenames for remote images that don't include a file extension
  • Updates the <Image> prop types to match docs, format isn't required for remote images

Testing

Tests added

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: 5835608

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 7, 2022
@tony-sull tony-sull merged commit db70afd into main Sep 7, 2022
@tony-sull tony-sull deleted the fix/remote-images-no-extname branch September 7, 2022 13:56
@astrobot-houston astrobot-houston mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/image] SSG build can break remote images without filename extensions in the URL
2 participants