No 👏 more 👏 server 👏 restarts 👏 on 👏 config 👏 changes #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67e22bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bholmesdev
commented
Aug 31, 2022
bholmesdev
commented
Aug 31, 2022
Comment on lines
+525
to
+533
| optimizeDeps: { entries: [] }, | ||
| clearScreen: false, |
There was a problem hiding this comment.
I noticed the screen refreshes with a warning statement on our Vite server fallback. entries prevents cache warnings, and clearScreen: false preserves output!
bholmesdev
commented
Aug 31, 2022
matthewp
reviewed
Aug 31, 2022
| configFlagPath && normalizePath(configFlagPath) === normalizePath(changedFile) | ||
| : // Otherwise, watch for any astro.config.* file changes in project root | ||
| new RegExp( | ||
| `${normalizePath(resolvedRoot)}.*astro\.config\.((mjs)|(cjs)|(js)|(ts))$` |
There was a problem hiding this comment.
what about .mts and .cts. j/k
There was a problem hiding this comment.
Therapist: cts doesn't exist in the docs, it can't hurt you.
cts:
matthewp
reviewed
Aug 31, 2022
|
Actually it also looks like windows tests are failing somehow 🥲 |
bluwy
reviewed
Sep 1, 2022
bholmesdev
force-pushed
the
feat/no-more-dev-server-restarts
branch
from
3cb90e6
to
2d0f4ce
Compare
natemoo-re
force-pushed
the
feat/no-more-dev-server-restarts
branch
from
153acca
to
1ef563a
Compare
natemoo-re
approved these changes
Sep 2, 2022
|
I added some better handling for invalid configs and cleaned up the messages a little bit! |
bholmesdev
commented
Sep 2, 2022
natemoo-re
reviewed
Sep 6, 2022
natemoo-re
approved these changes
Sep 7, 2022
|
Update: both of these are addressed! @natemoo-re actually needs a couple more things:
Both top priority tomorrow morning for me 👍 |
This was referenced Sep 8, 2022
This reverts commit 8ca8662.
bholmesdev
force-pushed
the
feat/no-more-dev-server-restarts
branch
from
7610862
to
67e22bd
Compare
github-actions
bot
added
pkg: lit
bholmesdev
commented
Sep 8, 2022
| @@ -469,7 +466,7 @@ const imageUrl = 'https://www.google.com/images/branding/googlelogo/2x/googlelog | |||
| ``` | |||
|
|
|||
| ## Troubleshooting | |||
| - If your installation doesn't seem to be working, make sure to restart the dev server. | |||
| - If your installation doesn't seem to be working, try restarting the dev server. | |||
There was a problem hiding this comment.
Tagging @sarah11918 from my docs PR earlier. Using this verbage now!
yanthomasdev
approved these changes
Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
restartInFlightflag to avoid clobbering when saving multiple times in a row--configis specified, only watch changes on that file. Otherwise, watch for any newastro.config.*files in the project root. Yes, this means your server reloads when you swap file extensions!About that
writeFilecall...All good PRs have some spice: When a config file changes, write the config contents to temporary file at the project root with a unique timestamp, and quickly delete once the config is resolved.
Proload uses a native ESM import to resolve
mjsandjsconfigs, which is great... until the file contents change. Re-importing a file in Node will not get the file's up-to-date contents; once a file is imported in an application, the contents are cached as long as the process is running. This approach writes to a new file path so Node will think it's a new import every time. This is informed by Vite's ESM loader, which does a similar write-read-then-delete strategy.I also considered writing to an internal
node_modules/.astrodirectory instead of the project root. However, managing the "if this directory exists..." logic and relying onnode_modulesbeing present felt like unneeded overhead. This temporary file only appears briefly during development (not production), and will be removed whenever an error in thrown during config resolution (seefinallyblock). Vite's comparable PR also writes to the project root for reference.Testing
TODO? Is it worth an E2E test?
Docs
TODO: check if "restart the server" recs are mentioned in the docs