Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "as Props" from the astro examples #4494

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Remove "as Props" from the astro examples #4494

merged 1 commit into from
Aug 26, 2022

Conversation

the-dijkstra
Copy link
Contributor

Changes

  • This changes the astro examples to remove as Props casting. since it's not needed any more with the new version of the asto language tools.

Testing

No tests were added, since the change only touches the examples.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

⚠️ No Changeset found

Latest commit: d85ba05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Aug 26, 2022
aFuzzyBear
aFuzzyBear reviewed Aug 26, 2022
View reviewed changes
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mohammed-elhaouari for doing this so quickly for us brother,
💚💚💚

@the-dijkstra
Copy link
Contributor Author

always a pleasure @aFuzzyBear

@matthewp
Copy link
Contributor

Nice improvement, thanks!

@matthewp matthewp merged commit 5fbb359 into withastro:main Aug 26, 2022
@the-dijkstra the-dijkstra deleted the refactor/remove-as-props-from-examples branch August 26, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aFuzzyBear aFuzzyBear aFuzzyBear left review comments

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@the-dijkstra @matthewp @aFuzzyBear