Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrations: update recommended method for running astro add #4340

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Aug 15, 2022

Changes

  • Updates astro add instructions in integrations READMES to use npm run astro add ... or pnpm run astro add ... instead of npx/pnpx

  • I assume no changes are needed for yarn as it already runs a named script when found so yarn astro add ... was and will be correct.

  • My perennial dilemma: should this include a patch changeset? Seems kind of drastic for a docs change this small.

Testing

N/A

Docs

YUP

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 41cef05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Aug 15, 2022
@hippotastic
Copy link
Contributor

For pnpm, I think it's even easier:

The exec/run part is optional when the command to be run is not in conflict with a builtin pnpm command, so you may also run:

pnpm astro ... - to execute Astro's CLI
pnpm dev - to run the dev script
pnpm build - to run the build script

I'm using this all the time.

@delucis
Copy link
Member Author

delucis commented Aug 16, 2022

Haha, double review with the same idea! Thanks — I’ll make that update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants