Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro 1.0.0 #4214

Merged
merged 11 commits into from
Aug 9, 2022
Merged

Astro 1.0.0 #4214

merged 11 commits into from
Aug 9, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Aug 9, 2022 •
edited
Loading

Changes

  • Releases Astro 1.0.0
  • I already ran changeset version, so merging this will trigger the release directly! No additional PR.
  • Packages not updated to 1.0.0
    • @astrojs/image
    • @astrojs/mdx
    • @astrojs/prefetch

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 48dc691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Aug 9, 2022
natemoo-re
natemoo-re commented Aug 9, 2022
View reviewed changes
packages/astro/CHANGELOG.md Show resolved Hide resolved
packages/create-astro/CHANGELOG.md Show resolved Hide resolved
package.json Show resolved Hide resolved
matthewp
matthewp reviewed Aug 9, 2022
View reviewed changes
package.json Show resolved Hide resolved
sarah11918
sarah11918 reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No typos! 🥳

Just comments re: GitHub's newer "note" and "warning" syntax that will format them nicer than a standard blockquote: I think you need to have the title/type of aside be its own > then start the message on the next line with another >

packages/astro/CHANGELOG.md Outdated Show resolved Hide resolved
packages/astro/CHANGELOG.md Outdated Show resolved Hide resolved
packages/astro/CHANGELOG.md Outdated Show resolved Hide resolved
packages/astro/CHANGELOG.md Show resolved Hide resolved
natemoo-re and others added 2 commits August 9, 2022 10:30
@natemoo-re @sarah11918
Update packages/astro/CHANGELOG.md
9f44557 
Co-authored-by: Sarah Rainsberger <[email protected]>
@natemoo-re @sarah11918
Update packages/astro/CHANGELOG.md
ab46a11 
Co-authored-by: Sarah Rainsberger <[email protected]>
@natemoo-re natemoo-re marked this pull request as ready for review August 9, 2022 15:59
@natemoo-re natemoo-re merged commit 9f067dc into main Aug 9, 2022
@natemoo-re natemoo-re deleted the chore/release branch August 9, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp left review comments

@Princesseuh Princesseuh Princesseuh left review comments

@sarah11918 sarah11918 sarah11918 left review comments

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@natemoo-re @matthewp @FredKSchott @Princesseuh @sarah11918