Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Github Codespace Config based on gitpod dockerfile #4185

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

mainawycliffe
Copy link
Contributor

This will ensure contributors using Github Codespaces have to correct environment setup, with all packages installed. Any changes to the .gitpod will be mirrored on Codespaces as they share the same dockerfile.

Changes

Doesn't change anything, just ensures that Github codespaces can be started with everything setup correctly.

Testing

This was tested manually as it's a config addition not a code change by running codespaces. You can do the same by going to my fork of the repo and opening Github Codespace under code.

Docs

No docs necessary atm.

This will ensure contributors using Github Codespaces also have to
correct environemnt setup, with all packages installed.
@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2022

⚠️ No Changeset found

Latest commit: d766dc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just pushed an update to rename the Dockerfile so it's more generic.

LGTM!

@natemoo-re natemoo-re merged commit f2989ec into withastro:main Aug 8, 2022
Copy link
Contributor

@ran-dall ran-dall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natemoo-re We actually already have a devcontainer setup (for users) we've been testing out on the Support Squad for some time, but it has yet to be upstreamed to GitHub because of some issues we're waiting to GitHub to respond on (#3982).

That said, fmu we wanted to start moving away from specific setups for every remote coding tool. Therefore, I think it would be best if we rewrote this in the new Developer Container specification (you can use the above-mentioned devcontainer.json, as a sample). This format allows for universal interoperability with GitPod, GitHub.dev, and Codespaces; and allows us to (eventually) get rid of the tool-specific dependencies (after GitPod has finished implementing devcontainer, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants