Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes local image resolution in SSR builds on Windows #4173

Merged
merged 7 commits into from
Aug 5, 2022

Conversation

tony-sull
Copy link
Contributor

Changes

Fixes a bug that was breaking local image resolution on Windows

Testing

All existing tests should pass

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: 1b666b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 5, 2022
@natemoo-re
Copy link
Member

Blocked by #4144 which ensures Windows tests are working as intended in CI.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is passing!

@tony-sull tony-sull marked this pull request as ready for review August 5, 2022 20:10
@tony-sull tony-sull merged commit 5811208 into main Aug 5, 2022
@tony-sull tony-sull deleted the fix/images-windows-bug branch August 5, 2022 20:36
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants