Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crawl non-style deps imported by styles #4115

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

natemoo-re
Copy link
Member

Changes

  • I hit a very strange bug during dev... every page included every hoisted script in the project, even though the component was not imported.
  • Turns out this was because of the way our crawlGraph utility interacted with Tailwind.
  • Tailwind treats every component in the project as an importedModule of the @tailwind base; entrypoint. We were crawling these because they seem like valid imports.
  • The fix is to check if the entrypoint is a style, and then only crawl the importedModules that are also styles. This sidesteps the over-eager hoisting.

Testing

Tested manually, there's not a great way to test this edge case.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

🦋 Changeset detected

Latest commit: 9c3f8ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants