Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings on markdown deprecations #4046

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Add warnings on markdown deprecations #4046

merged 3 commits into from
Jul 25, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Adds warning when attempting to read from content.astro.headers.
  • Adds warning when using setup: in frontmatter without the astroFlavoredMarkdown legacy flag enabled.

Testing

Just manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f2a7e38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 25, 2022
tony-sull
tony-sull approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthewp matthewp merged commit c811be4 into main Jul 25, 2022
@matthewp matthewp deleted the new-warnings branch July 25, 2022 19:14
@astrobot-houston astrobot-houston mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-sull tony-sull tony-sull approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @tony-sull