Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve authored CSS specificity #4024

Merged
merged 5 commits into from
Jul 23, 2022
Merged

Preserve authored CSS specificity #4024

merged 5 commits into from
Jul 23, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jul 22, 2022

Changes

- div.astro-XXXXXX {
+ div:where(.astro-XXXXXX) {
  color: red;
}
  • In effect, this behavior will preserve the specificity of your selectors as authored, leading to much more stable default behavior.
  • If you were relying on the specificity increase provided by the previous behavior, please update your selectors to include an additional class. This will match the old behavior.
<style>
- div {
+ div.my-class {
  color: red;
}
</style>

Testing

Using CI

Docs

Will be added to migration guide

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2022

🦋 Changeset detected

Latest commit: ce34ed6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 22, 2022
@natemoo-re natemoo-re mentioned this pull request Jul 23, 2022
20 tasks
@natemoo-re
Copy link
Member Author

Giving myself approval to merge this once tests pass, since withastro/compiler#330 (the actual change) was approved.

@natemoo-re natemoo-re merged commit 1215e73 into main Jul 23, 2022
@natemoo-re natemoo-re deleted the feat/scope-spec branch July 23, 2022 18:11
@astrobot-houston astrobot-houston mentioned this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant