Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDX] Add Prism and Shiki support #4002

Merged
merged 21 commits into from
Jul 21, 2022
Merged

[MDX] Add Prism and Shiki support #4002

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ebb2232
deps: add rehype-prism, shiki, rehype-pretty-code
bholmesdev Jul 20, 2022
39f48dd
wip: apply rehype plugins depending on config
bholmesdev Jul 20, 2022
b4958f6
wip: cherry-pick jsx-runtime fix?
natemoo-re Jul 20, 2022
deecec2
deps: rehype-pretty-code -> shiki-twoslash, add rehype-raw
bholmesdev Jul 21, 2022
07f4528
wip: add jsx-runtime fix
bholmesdev Jul 21, 2022
435c84d
feat: get shiki working!
bholmesdev Jul 21, 2022
fd1922c
deps: add @astrojs/prism, prismjs, unist-util-visit
bholmesdev Jul 21, 2022
67485e2
feat: add prism support
bholmesdev Jul 21, 2022
e0f5132
example: add small syntax highlight demo to with-mdx
bholmesdev Jul 21, 2022
92a4a60
deps: remove rehype-prism
bholmesdev Jul 21, 2022
515d851
chore: remove unused async
bholmesdev Jul 21, 2022
2a7ac3d
Merge branch 'main' into feat/mdx-shiki
bholmesdev Jul 21, 2022
d0056a8
chore: add .test.js to all mdx tests
bholmesdev Jul 21, 2022
65889fb
test: shiki, shikiConfig, prism
bholmesdev Jul 21, 2022
e732f01
fix: remove "is:raw" from prism output
bholmesdev Jul 21, 2022
18cee51
docs: add syntax highlighting section
bholmesdev Jul 21, 2022
d05d846
chore: add changeset
bholmesdev Jul 21, 2022
2a51360
nit: "Shiki config" -> Shiki config
bholmesdev Jul 21, 2022
af08eb8
Revert "wip: add jsx-runtime fix"
bholmesdev Jul 21, 2022
90b7a83
Merge branch 'main' into feat/mdx-shiki
bholmesdev Jul 21, 2022
7ab7794
docs: link to integration README from example
bholmesdev Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "wip: add jsx-runtime fix" 
This reverts commit 07f4528.
  • Loading branch information
@bholmesdev
bholmesdev committed Jul 21, 2022
commit af08eb81411c644d251a49f58569078739eba4a4
2 changes: 0 additions & 2 deletions packages/astro/src/runtime/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,6 @@ export function createAstro(
const toAttributeString = (value: any, shouldEscape = true) =>
shouldEscape ? String(value).replace(/&/g, '&').replace(/"/g, '"') : value;

const kebab = (k: string) => k.toLowerCase() === k ? k : k.replace(/[A-Z]/g, match => `-${match.toLowerCase()}`);
const toStyleString = (obj: Record<string, any>) => Object.entries(obj).map(([k, v]) => `${kebab(k)}:${v}`).join(';')
const STATIC_DIRECTIVES = new Set(['set:html', 'set:text']);

// A helper used to turn expressions into attribute key/value
Expand Down