Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add snowpack workspace root to starter #399

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

duncanhealy
Copy link
Contributor

Changes

Testing

  • Tests are passing
  • Tests updated where necessary

Docs

  • Docs / READMEs updated
  • Code comments added where helpful

closes #394

@duncanhealy duncanhealy requested a review from a team as a code owner June 11, 2021 23:03
@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/astro-www/A4cMpKbTRMr6X8d7RWvXFdmmB5vy
✅ Preview: https://astro-www-git-chore-add-workspace-root-to-starter-pikapkg.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2021

⚠️ No Changeset found

Latest commit: d819b37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@duncanhealy duncanhealy merged commit 2d7abd3 into main Jun 11, 2021
@duncanhealy duncanhealy deleted the chore/add-workspace-root-to-starter branch June 11, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Starter template fails to build
2 participants