Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the images integration to automatically mark optimizeDeps for sharp #3795

Merged
merged 4 commits into from
Jul 1, 2022

Conversation

tony-sull
Copy link
Contributor

Changes

  • Updates the integration to add sharp and image-size to the vite.optimizeDeps config
  • Fixes a bug when resizing images - sharp requires all dimensions are provided as whole numbers
  • Updates the file exports in the NPM package to support the Image.astro typescript imports at build time

Testing

All existing tests should pass

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022

🦋 Changeset detected

Latest commit: d042fec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 1, 2022
@tony-sull tony-sull changed the title Fix Updates the images integration to automatically mark optimizeDeps for sharp Jul 1, 2022
@tony-sull tony-sull merged commit d143d24 into main Jul 1, 2022
@tony-sull tony-sull deleted the fix/image-deps branch July 1, 2022 19:56
@astrobot-houston astrobot-houston mentioned this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant