Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@astrojs/telemetry): add optional integrations field #3614

Merged
merged 12 commits into from
Jun 16, 2022

Conversation

okikio
Copy link
Member

@okikio okikio commented Jun 16, 2022

Changes

Testing

Docs

  • No docs necessary.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: d284529

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/telemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @okikio!

Edit: I've caught up on the discussion in #3606. I don't think this is a bad stat to have, but I'm not positive how much value it adds either.

The code looks good! I don't have a strong opinion on merging this or holding off.

@matthewp matthewp merged commit 9c8a7c0 into withastro:main Jun 16, 2022
@github-actions github-actions bot mentioned this pull request Jun 16, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great find here, thanks for the clean fix and test coverage!

@okikio okikio changed the title fix(@astrojs/telemetry): add optional integrations field fix(@astrojs/telemetry): astro dev/build crashing when using optional integrations + add optional integrations field Jun 17, 2022
@okikio okikio changed the title fix(@astrojs/telemetry): astro dev/build crashing when using optional integrations + add optional integrations field fix(@astrojs/telemetry): add optional integrations field Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants