Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inlined hoisted scripts and SSR #3593

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix inlined hoisted scripts and SSR #3593

merged 2 commits into from
Jun 14, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added. Failed before the fix.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2022

🦋 Changeset detected

Latest commit: d8df8f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp marked this pull request as ready for review June 14, 2022 18:05
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 14, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling quickly.

@matthewp matthewp merged commit 0e2314d into main Jun 14, 2022
@matthewp matthewp deleted the hoisted-script-ssr branch June 14, 2022 19:14
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix inlined hoisted scripts and SSR

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: SSR breaks scripts (i.e. scripts are no longer loaded on page)
2 participants