Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Issue creation link #3421

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

retronav
Copy link
Contributor

This PR closes #3257

Changes

  • Add IDs to bug report issue form
  • Replace 'body' with correct input id for prefilling form

Testing

This approach was tested by creating a fresh repository, creating an issue template with ids for each input box in the form, constructing a URL and opening it to see if it works. It worked.

Additional information: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#keys

Docs

No docs required

Additional information (unrelated)

I don't know why but this commit is falsely shown as "Unverified" even if I signed it with one of my GPG keys. Maybe it is because I uploaded the public key to GitHub after making this commit, and the fact that I was using GitHub Codespaces and not my local computer.

* Add IDs to bug report issue form
* Replace 'body' with correct input id for prefilling form
@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

🦋 Changeset detected

Latest commit: 6a2854e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 23, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! This is great.

Test failure seems unrelated, will re-run and merge if passing.

@natemoo-re natemoo-re merged commit 63c26c1 into withastro:main May 23, 2022
@github-actions github-actions bot mentioned this pull request May 23, 2022
@retronav retronav deleted the fix/gh-issue-link branch May 23, 2022 18:07
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Add IDs to bug report issue form
* Replace 'body' with correct input id for prefilling form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Issue creation link in terminal does not work
2 participants