Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer head injection until renderPage #3408

Merged
merged 2 commits into from
May 19, 2022
Merged

Defer head injection until renderPage #3408

merged 2 commits into from
May 19, 2022

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Test added

Docs

Bug fix only

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 19, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 7da858a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sarah11918
Copy link
Member

Will this fix affect anything noted in this Docs issue reported here, which describes using <head> in an Astro component? (Namely, that if you do, you must also include <html> and <body> in that same component?)
withastro/docs#257

@natemoo-re
Copy link
Member Author

Will this fix affect anything noted in this Docs issue reported here, which describes using <head> in an Astro component? (Namely, that if you do, you must also include <html> and <body> in that same component?) withastro/docs#257

Great question! The behavior mentioned in that issue will no longer be the case after this PR is merged. We should now be following RFC0007, which means that some Astro component somewhere on your page needs to render a head element, but other than that, html and body can be placed in any component (or not included for the minimalists among us.)

@natemoo-re natemoo-re merged commit b26d48d into main May 19, 2022
@natemoo-re natemoo-re deleted the fix/head-inject branch May 19, 2022 20:21
@github-actions github-actions bot mentioned this pull request May 19, 2022
Merged
@sarah11918 sarah11918 mentioned this pull request Jun 7, 2022
Closed
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
Defer head injection until renderPage (withastro#3408)
8f1521b 
* fix(withastro#3195, withastro#3197): only perform head injection for renderPage

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: <head> delegated to component does not inject hydration scripts
3 participants
@natemoo-re @sarah11918 @matthewp