Provide a good error message when loading react spectrum #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41276b8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
force-pushed
the
err-react-spectrum
branch
from
b669af4
to
41276b8
Compare
Merged
FredKSchott
reviewed
May 19, 2022
| function generateHint(err: ErrorWithMetadata): string | undefined { | ||
| if (/Unknown file extension \"\.(jsx|vue|svelte|astro)\" for /.test(err.message)) { | ||
| return 'You likely need to add this package to `vite.ssr.noExternal` in your astro config file.'; | ||
| } else { |
There was a problem hiding this comment.
Since we expect this function to grow over time, it would be good to get it into this structure for the future:
if (...) {
return ...;
}
if (...) {
return ...;
}
if (...) {
No need to fix now since this has already merged, but just a thought to remember next time we edit this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@adobe/react-spectrumwhich is not compatible with Vite SSR.Testing
Test added
Docs
N/A, bug fix