Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests: remove it.only #3394

Merged
merged 2 commits into from
May 18, 2022
Merged

Fix tests: remove it.only #3394

merged 2 commits into from
May 18, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Test change only

Testing

I was extremely confused why tests weren't running. Finally tracked down the culprit as a stray it.only!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6d289b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 17, 2022
tony-sull
tony-sull approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Great catch! Crazy that it.only tears burns everything to the ground...

bholmesdev
bholmesdev approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only took this fix?

@matthewp matthewp merged commit 1297c10 into main May 18, 2022
@matthewp matthewp deleted the fix/it-only branch May 18, 2022 12:27
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
Fix tests: remove it.only (withastro#3394)
480b997 
* test: remove it.only

* test: skip failure until withastro#3376 is revisited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@tony-sull tony-sull tony-sull approved these changes

@bholmesdev bholmesdev bholmesdev approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natemoo-re @matthewp @tony-sull @bholmesdev