Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: locale handling for logger #3391

Merged
merged 4 commits into from
May 18, 2022
Merged

fix: locale handling for logger #3391

merged 4 commits into from
May 18, 2022

Conversation

natemoo-re
Copy link
Member

Changes

Testing

  • Regression tests added

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: 4f307f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) labels May 17, 2022
@Princesseuh Princesseuh marked this pull request as draft May 17, 2022 21:05
@natemoo-re natemoo-re marked this pull request as ready for review May 18, 2022 15:38
@natemoo-re natemoo-re merged commit cf8015e into main May 18, 2022
@natemoo-re natemoo-re deleted the fix/locale branch May 18, 2022 15:45
@github-actions github-actions bot mentioned this pull request May 18, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix(withastro#3309): use system default locale

* fix(withastro#3309): use system default locale in create-astro

* test: add locale regression tests

* test: add i18n regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: RangeError: Incorrect locale information provided
2 participants