Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching custom 404 pages using the manifest's route patterns #3390

Merged
merged 2 commits into from
May 17, 2022
Merged

Matching custom 404 pages using the manifest's route patterns #3390

merged 2 commits into from
May 17, 2022

Conversation

tony-sull
Copy link
Contributor

@tony-sull tony-sull commented May 17, 2022 •
edited
Loading

Closes #3389

Changes

Updates the dev server to support using markdown pages for custom 404 routes (this already works in astro preview)

Testing

Added a test fixture for custom 404.md pages

Docs

Related to PR #554

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a231a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 17, 2022
@tony-sull tony-sull changed the title WIP: Matching custom 404 pages using the manifest's route patterns Matching custom 404 pages using the manifest's route patterns May 17, 2022
@tony-sull tony-sull marked this pull request as ready for review May 17, 2022 20:31
@tony-sull tony-sull merged commit d8e5dfb into main May 17, 2022
@tony-sull tony-sull deleted the fix/custom-404-md branch May 17, 2022 21:27
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Matching custom 404 pages using the manifest's route patterns (withas…
93a5e4b 
…tro#3390)

* matching custom 404 pages using the manifest's route patterns

* windows: still need to use the relative paths for 404 matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 404.md ignored in the dev server
3 participants
@tony-sull @matthewp @natemoo-re