Adding E2E testing with Playwright #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
|
Can you update the CONTRIBUTING.md and explain how to run these. Also an explanation of how to run an individual test (rather than all of them) would be great. |
tony-sull
force-pushed
the
test/playwright-e2e
branch
4 times, most recently
from
9ee980a
to
1cccce8
Compare
tony-sull
changed the title
tony-sull
force-pushed
the
test/playwright-e2e
branch
from
e8fa46c
to
a17921c
Compare
matthewp
approved these changes
May 13, 2022
tony-sull
force-pushed
the
test/playwright-e2e
branch
from
a17921c
to
7ea9c16
Compare
added 12 commits
May 15, 2022 11:51
This reverts commit 48496f4.
tony-sull
force-pushed
the
test/playwright-e2e
branch
from
7ea9c16
to
c9a2a9e
Compare
tony-sull
force-pushed
the
test/playwright-e2e
branch
from
915bd55
to
ee16c14
Compare
tony-sull
force-pushed
the
test/playwright-e2e
branch
from
946f54d
to
ac62f7d
Compare
florian-s-code
pushed a commit
to florian-s-code/astro
that referenced
this pull request
May 16, 2022
* adding Tailwind E2E tests with Playwright * package.json updates * adding e2e tests to CI workflow * using e2e for dev tests, mocha for build tests * refactor: sharing test-utils helpers * chore: update lockfile * Adding contributing docs * Revert "refactor: sharing test-utils helpers" This reverts commit 48496f4. * refactor: simpler solution to resolving e2e test fixtures * chore: updating lockfile * refactor: cleaning up how URLs are resolved in e2e tests * install playwright deps in CI * trying pnpm playwright install to fix version mismatch
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* adding Tailwind E2E tests with Playwright * package.json updates * adding e2e tests to CI workflow * using e2e for dev tests, mocha for build tests * refactor: sharing test-utils helpers * chore: update lockfile * Adding contributing docs * Revert "refactor: sharing test-utils helpers" This reverts commit 48496f4. * refactor: simpler solution to resolving e2e test fixtures * chore: updating lockfile * refactor: cleaning up how URLs are resolved in e2e tests * install playwright deps in CI * trying pnpm playwright install to fix version mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Includes Playwright for E2E testing. The proof of concept migrates over our Tailwind tests to better validate rendered CSS styles, but with a few extra test utils we'll also be able to do proper HMR testing 🎉
Testing
That's all it is!
Docs
None, test coverage only