Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tailwind integration in markdown files #3305

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix tailwind integration in markdown files #3305

merged 2 commits into from
May 6, 2022

Conversation

obj-obj
Copy link
Contributor

@obj-obj obj-obj commented May 5, 2022

Changes

Add markdown to the default content files in the tailwind integration. This fixes an issue I was having (if you add a tailwind class to a div or other html component in markdown, tailwind wouldn't generate the new class).

Testing

So far, it works fine in my own project.

Docs

Doesn't need docs

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

⚠️ No Changeset found

Latest commit: 9a027ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 5, 2022
@obj-obj
Copy link
Contributor Author

obj-obj commented May 5, 2022

me when 3 character PR

@matthewp
Copy link
Contributor

matthewp commented May 6, 2022

I'm confused, this doesn't change the tailwind integration, this only changes a test fixture. Did you modify the wrong file?

@obj-obj
Copy link
Contributor Author

obj-obj commented May 6, 2022

I'm confused, this doesn't change the tailwind integration, this only changes a test fixture. Did you modify the wrong file?

Yeah it was the wrong file, I don't know much about the code structure so I just searched for src/**/*.{astro,html,js,jsx,svelte,ts,tsx,vue} in the code to hopefully find the default config file. Didn't see there were 3 instances of it though

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label May 6, 2022
@matthewp
Copy link
Contributor

matthewp commented May 6, 2022

Thanks!

@matthewp matthewp merged commit 2864d09 into withastro:main May 6, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix tailwind integration in markdown files

* 3 character PR -> 9 character PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants