Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server options configuration reference #3295

Merged
merged 1 commit into from
May 7, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented May 4, 2022

Changes

Brings across some updates to the server config options @RafidMuhymin proposed on the docs repo but which need updating in the types file.

Closes withastro/docs#422

Testing

Docs only.

Docs

See above 馃槂

@delucis delucis requested a review from RafidMuhymin May 4, 2022 22:36
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

鈿狅笍 No Changeset found

Latest commit: cd77c7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 4, 2022
@RafidMuhymin
Copy link
Member

Thank you @delucis for correcting the PR. Looks good to me! 馃憤

@delucis delucis merged commit ee55d49 into main May 7, 2022
@delucis delucis deleted the delucis/docs/server-opts branch May 7, 2022 07:56
@delucis
Copy link
Member Author

delucis commented May 7, 2022

馃槵 Looks like a CI task updating the latest branch failed. Maybe I shouldn't have merged on a Saturday 馃う

Looks like it failed for the last few merges but still.

SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Based on withastro/docs#422

Co-Authored-By: Rafid Muhymin Wafi <[email protected]>

Co-authored-by: Rafid Muhymin Wafi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants