Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose pages #3286

Merged
merged 3 commits into from
May 4, 2022
Merged

feat: expose pages #3286

merged 3 commits into from
May 4, 2022

Conversation

thepassle
Copy link
Contributor

@thepassle thepassle commented May 4, 2022 •
edited
Loading

Changes

  • What does this change?
    Exposes a pages property in the astro:build:setup hook as discussed in: Service Worker Side Rendering roadmap#188 (reply in thread) The comment suggests to add a new hook, but it seemed like it makes more sense to just add it to the setup hook instead rather than giving it it's entire own special hook.

Testing

Tested locally

Docs

The astro:build:setup hook wasnt yet documented at all, so I added it here as well: withastro/docs#433

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 1648ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thepassle thepassle mentioned this pull request May 4, 2022
Merged
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 4, 2022
@matthewp
Copy link
Contributor

matthewp commented May 4, 2022

Great! I had actually forgotten about this hook. Have you been able to get your SW integration working the way we described in that RFC with this change?

@thepassle
Copy link
Contributor Author

Great! I had actually forgotten about this hook. Have you been able to get your SW integration working the way we described in that RFC with this change?

Yep!
image

You can see it in action here (line 173) and locally totally works as expected: https://gist.github.com/thepassle/be9010c330d7524133a4cfcf0a1c2ea1

@matthewp
Copy link
Contributor

matthewp commented May 4, 2022

Ok great, I don't see any downside to this change, so going to merge.

@matthewp matthewp merged commit e5f6de4 into withastro:main May 4, 2022
@github-actions github-actions bot mentioned this pull request May 4, 2022
Merged
nonphoto pushed a commit to nonphoto/astro that referenced this pull request May 6, 2022
@thepassle @nonphoto
feat: expose pages (withastro#3286)
a1ab13d 
* feat: expose pages

* chore: changeset

* fix: build
@matthewp matthewp mentioned this pull request Jan 3, 2023
Closed
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@thepassle
feat: expose pages (withastro#3286)
a12be1a 
* feat: expose pages

* chore: changeset

* fix: build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thepassle @matthewp