Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unintended changelogs #3233

Merged
merged 3 commits into from
Apr 29, 2022
Merged

chore: remove unintended changelogs #3233

merged 3 commits into from
Apr 29, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Apr 28, 2022 •
edited
Loading

Changes

Removed changelogs inside examples and astro-scripts. Plus, added astro-scripts to Changeset config ignore

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c8fa04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Apr 28, 2022
@FredKSchott
Copy link
Member

Looks like this isn't possible, based on the error output in the changeset bot above. Would love the PR to remove these CHANGELOG files though, if you'd like to trim the PR down to just that

@JuanM04
Copy link
Contributor Author

JuanM04 commented Apr 28, 2022

@FredKSchott seems like anything exploded with this revert

@FredKSchott
Copy link
Member

LGTM!

@FredKSchott FredKSchott merged commit 6cd9ef5 into main Apr 29, 2022
@FredKSchott FredKSchott deleted the juanm04/remove-changelogs branch April 29, 2022 15:41
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@JuanM04
chore: remove unintended changelogs (withastro#3233)
44e9d68 
* Removed unused CHANGELOGS

* Added `astro-scripts` to changeset ignore

* Reverted config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JuanM04 @FredKSchott