Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: astro add generating config outside project root #3186

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

Append trailing slash to project root to fix astro.config.mjs path resolution

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2022

🦋 Changeset detected

Latest commit: d1e6e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 22, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 2b702d6 into main Apr 22, 2022
@bholmesdev bholmesdev deleted the fix/astro-add-generated-config-file-path branch April 22, 2022 19:17
@github-actions github-actions bot mentioned this pull request Apr 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: astro.config generated outside project dir

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants