Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [create-astro] remove online editor configs from output #3175

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

Removes .stackblitzrc and sandbox.config.json from create-astro output. These are helpful when generating from the astro.new command, but not necessary for local development with our CLI tool.

Testing

Debated whether it was worth killing a tree to test this change on our test runner every time. For a small change like this, I decided against it 🙃

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2022

⚠️ No Changeset found

Latest commit: 0a7a0aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Apr 22, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bholmesdev bholmesdev merged commit eda4979 into main Apr 22, 2022
@bholmesdev bholmesdev deleted the feat/create-astro-remove-editor-configs branch April 22, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants