Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to build and dev when building for subpaths #3156

Merged
merged 14 commits into from
Apr 21, 2022
Merged

Improvements to build and dev when building for subpaths #3156

merged 14 commits into from
Apr 21, 2022

Commits on Apr 20, 2022

  1. astro build should include the base provided in astro config

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    66e2f56 View commit details
    Browse the repository at this point in the history

  2. test: updating build test to expect the base path in links/scripts

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f72a3e5 View commit details
    Browse the repository at this point in the history

  3. ignore the default "base" value when building links/scripts

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8d47bc4 View commit details
    Browse the repository at this point in the history

  4. fix: handling config that provides a base but no site

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    6567ddc View commit details
    Browse the repository at this point in the history

  5. fix: config.site was being ignored since it's a URL not a string

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    cb958ae View commit details
    Browse the repository at this point in the history

  6. hack: handle base path in dev for /public assets

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c0c485a View commit details
    Browse the repository at this point in the history

  7. fix: dev redirect needs to ignore base default of ./

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    5d11034 View commit details
    Browse the repository at this point in the history

  8. fix: extra safety checks for the base path redirect

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    84d5c73 View commit details
    Browse the repository at this point in the history

  9. refactor: simplifying it to remove the regex

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9bf2a08 View commit details
    Browse the repository at this point in the history

  10. one last safety check - only redirect GET and use a 302 status

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4ada547 View commit details
    Browse the repository at this point in the history

  11. fix: lost the leading slash when redirecting

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    2b3e2bb View commit details
    Browse the repository at this point in the history

  12. nit: adding comments to the test explaining how base is verified

    Tony Sullivan committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    96e82fd View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Remove extra console.log

    @matthewp
    matthewp committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ef1d874 View commit details
    Browse the repository at this point in the history

  2. Adds a changeset

    @matthewp
    matthewp committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c13a936 View commit details
    Browse the repository at this point in the history