Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ssr url search params bug #3066

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix ssr url search params bug #3066

merged 1 commit into from
Apr 11, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Apr 11, 2022

Changes

Testing

  • Added.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: cc7471e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 11, 2022
@@ -49,7 +49,6 @@ function printAstroHelp() {
['--config <path>', 'Specify the path to the Astro config file.'],
['--root <path>', 'Specify the path to the project root folder.'],
['--legacy-build', 'Use the build strategy prior to 0.24.0'],
['--experimental-ssr', 'Enable SSR compilation fot 3rd-party adapters.'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it seems that some unwanted changes got leaked

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional! I believe we agreed in a separate convo that experimental flags should not be documented in the CLI output, since you should only need to worry/know about them when Astro is complaining about it to you directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I didn't know about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! I should have added a comment here for reviewers

@FredKSchott FredKSchott merged commit 5b3464a into main Apr 11, 2022
@FredKSchott FredKSchott deleted the fix-url-search-params-bug branch April 11, 2022 22:57
@FredKSchott
Copy link
Member Author

Self-merging as steward since core team is out today, and this is small.

@github-actions github-actions bot mentioned this pull request Apr 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants