Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused renderers #3063

Merged
merged 1 commit into from
Apr 11, 2022
Merged

remove unused renderers #3063

merged 1 commit into from
Apr 11, 2022

Conversation

FredKSchott
Copy link
Member

Changes

  • We've had a few weeks now since integrations were released and renderers were deprecated
  • There's a maintenance cost to keeping these around (see fix: Nested hydration with Solid #3003, where the contributor didn't realize that the renderer no longer needed an update)

Testing

  • Covered by existing tests.

Docs

  • Should be okay, I don't think we linked to these directly

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6ba53d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Apr 11, 2022
JuanM04
JuanM04 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FredKSchott FredKSchott merged commit 771127e into main Apr 11, 2022
@FredKSchott FredKSchott deleted the remove-unused-renderers branch April 11, 2022 18:19
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
remove unused renderers (withastro#3063)
925a4a0
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
remove unused renderers (withastro#3063)
eefae57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanM04 JuanM04 JuanM04 approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredKSchott @JuanM04