Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: webapi tests now use chai #3048

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Apr 9, 2022

Changes

Now webapi uses test with Chai, the same way all the other packages do. The motivation behind this is that I've always had problems in my computer with the custom implementation of tests and Mocha not detecting any test suite

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2022

⚠️ No Changeset found

Latest commit: 27f4f54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JuanM04 JuanM04 changed the title chore: webapi test now use chai refactor: webapi test now use chai Apr 9, 2022
@JuanM04 JuanM04 requested a review from natemoo-re April 9, 2022 17:03
@JuanM04 JuanM04 changed the title refactor: webapi test now use chai refactor: webapi tests now use chai Apr 9, 2022
@FredKSchott
Copy link
Member

LGTM with tests passing!

@FredKSchott FredKSchott merged commit 1907255 into main Apr 11, 2022
@JuanM04 JuanM04 deleted the chore/updated-webapi-test branch April 11, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants