Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove site requirement from netlify adapter #3041

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

FredKSchott
Copy link
Member

Changes

  • remove the requirement for site config by using event.rawUrl
  • also, added handling for body while I was there
  • I can't believe this event API isn't better documented!

Testing

  • Verified locally

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2022

⚠️ No Changeset found

Latest commit: de69ed4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthewp
Copy link
Contributor

matthewp commented Apr 9, 2022

Lgtm, didn't know rawUrl was a thing

@FredKSchott FredKSchott merged commit fbc32cf into main Apr 10, 2022
@FredKSchott
Copy link
Member Author

also: this fixes an issue where query params were being stripped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants