Fix SSR static build public file copying. fixes #3016 #3037
Conversation
🦋 Changeset detectedLatest commit: 077b1ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
I couldn't figure the CI lockfile error. I previously looked for lock file in fixture but did not see one d o I simply added the SSR symblink in node modules. |
|
I meant to say that an alternative is to use something like |
There was a problem hiding this comment.
Looks good! Not sure about using npath.dirname with a URL, but I'll let @matthewp weigh in.
|
natemoo-re yeah i think that would be fine and better fits the rest of the code. I just used what I'd used before in path manipulations |
|
@matthewp So The function "async function ssrMoveAssets(opts: StaticBuildOptions)" would appear to have the same issue. Except - I suspect only the root folder needs to be moved, not all the sub files/folders. |
SteveALee
changed the title
|
LGTM! In the future, try to avoid source files/folders with spaces in the name, it can be a nightmare to type out or copy-paste into the terminal. I'll update for you post-merging the PR. |
|
@FredKSchott oh gosh, I introduced a filename bug? Sorry. I'm at a loss to how that happened - I usually use kebab case and thought I just copied the existing test file. My only excuse is a new monitor has defaulted to smaller text and I thought I could cope - lol But thanks for accepting - I'm well chuffed to have contributed. Huzzah! |
|
No worries! I think you did copy an existing test, which I hadn't realized when I commented. No worries at all :) |
…stro#3037) * Fix SSR static build public file copying * chore: update lockfile * remove dirname and use URL constructor * Cleanup test and actually test what it says it tests Co-authored-by: Nate Moore <[email protected]>
Changes
Testing
Test added to static -build.test.js
Docs
none