Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the Markdown component in SSR #3036

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Support the Markdown component in SSR #3036

merged 5 commits into from
Apr 14, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 8, 2022

Changes

  • This adds support for the <Markdown> component in SSR.

Testing

  • Tests added.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 6ad93a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 8, 2022
@matthewp matthewp marked this pull request as ready for review April 8, 2022 13:00
natemoo-re
natemoo-re approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass!

@matthewp
Copy link
Contributor Author

matthewp commented Apr 8, 2022

@natemoo-re tests are not passing because the Deno adapter needs everything to be bundled, but we can't bundle @astrojs/markdown-remark because it depends on a lot of Node builtin packages.

Should we go back to bundling this package like we used to?

@natemoo-re
Copy link
Member

Ooh good point, I did not consider all of that... hmm. Let's chat in person probably!

@matthewp matthewp self-assigned this Apr 8, 2022
@FredKSchott FredKSchott marked this pull request as draft April 11, 2022 01:18
@JuanM04 JuanM04 mentioned this pull request Apr 11, 2022
Merged
@matthewp matthewp mentioned this pull request Apr 13, 2022
Closed
1 task
@matthewp
Copy link
Contributor Author

Fixes #3036

@thepassle
Copy link
Contributor

@natemoo-re Was any resolution found wrt bundling the @astrojs/markdown-remark package?

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 14, 2022
@matthewp matthewp marked this pull request as ready for review April 14, 2022 13:39
@matthewp
Copy link
Contributor Author

@thepassle It can't be bundled. The solution is that we import it dynamically on usage. This means it only works on Node.js runtimes, unfortunately. We are discussing alternatives for the future.

@thepassle
Copy link
Contributor

Thanks for looking into it, I appreciate it 🙂 At least im unblocked for now 😄

@matthewp matthewp merged commit 4ac0d5d into main Apr 14, 2022
@matthewp matthewp deleted the ssr-markdown branch April 14, 2022 13:51
@github-actions github-actions bot mentioned this pull request Apr 14, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Support the Markdown component in SSR (withastro#3036)
df6a9f3 
* Support the Markdown component in SSR

* Adds a changeset

* Support runtime markdown in Node.js

* Remove option from test adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees

@matthewp matthewp

Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewp @natemoo-re @thepassle