Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2987): relative config handling with --config flag #3001

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Tests updated to ensure coverage

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: ffdd8e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 5, 2022
@natemoo-re natemoo-re self-assigned this Apr 6, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling very configdent about this

@natemoo-re natemoo-re merged commit 25cc921 into main Apr 6, 2022
@natemoo-re natemoo-re deleted the fix/relative-config branch April 6, 2022 21:39
This was referenced Apr 6, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…ithastro#3001)

* fix(withastro#2987): relative config handling with `--config` flag

* test: fix tests

* fix: improve config test for failure case

* fix: test on windows?

* fix: test on windows?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Config flag does not support relative paths or warn if file not found
2 participants