Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the new config defaults (docs only) #2973

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Conversation

tony-sull
Copy link
Contributor

@tony-sull tony-sull commented Apr 3, 2022

Fixes #2972

Changes

Docs fix only - config.publicDir and config.outDir were showing the wrong default values

Testing

None (docs and typedef fix only)

Docs

None, this will be picked up by the doc's docgen script

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2022

🦋 Changeset detected

Latest commit: 3deb116

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 3, 2022
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch man, I think its safe to merge this,

@tony-sull tony-sull changed the title Fixing the default value documented for config.publicDir Fixing the new config defaults (docs only) Apr 3, 2022
@tony-sull tony-sull merged commit 7591953 into main Apr 3, 2022
@github-actions github-actions bot mentioned this pull request Apr 3, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* updating the default listed in config jsdocs

* chore: adding changeset

* outDir had the wrong default listed as well

* chore: updating changeset description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 0.26.0 needs publicDir declaration
2 participants