Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the favicon for the starter example #2940

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

gtnbssn
Copy link
Contributor

@gtnbssn gtnbssn commented Mar 30, 2022

Changes

  • the favicon was in fact a text file with this content: https://rawcdn.githack.com/withastro/astro/main/examples/starter/public/favicon.ico
  • my browser was displaying another favicon it had cached somehow, but it was also triggering 404 of course
  • this is the actual image, fetched from another example

Testing

If you really have to:

npm init astro testFavicon
cd testFavicon
npm i
npm run dev

Docs

Probably not required.

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Mar 30, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure what happened here, but really appreciate the fix!

@natemoo-re natemoo-re merged commit e860408 into withastro:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants