Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CSS from being added to pages not using it #2918

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Prevent CSS from being added to pages not using it #2918

merged 4 commits into from
Mar 28, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Since we are bundling into a single file for the build now, we need to do CSS slightly differently.
  • This changes the static build so that at the end of the build it walks the module graph and collects the CSS for each page and builds a bundle based on that, rather than relying on Rollup's chunking; there is only 1 chunk so that way can't work now.
  • Fixes 🐛 BUG: <style global> appears on pages that it shouldn't, build only #2908

Testing

Test added

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d4ee998

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Mar 28, 2022
FredKSchott
FredKSchott approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small comments around docs and defensive coding

@matthewp matthewp merged commit 77354c8 into main Mar 28, 2022
@matthewp matthewp deleted the page-level-styles branch March 28, 2022 20:48
@github-actions github-actions bot mentioned this pull request Mar 28, 2022
Merged
@bholmesdev bholmesdev mentioned this pull request Apr 7, 2022
Closed
1 task
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Prevent CSS from being added to pages not using it (withastro#2918)
caa4485 
* Prevent CSS from being added to pages not using it

* Adds a changeset

* Add clarification when the CSS is appended to the pageData

* Move addStyles up a level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: <style global> appears on pages that it shouldn't, build only
2 participants
@matthewp @FredKSchott