chore: remove @astrojs/parser
#2845
Conversation
|
github-actions
bot
added
the
pkg: astro
|
I'm not 100% sure we're ready to do this yet, since our prettier extension is still using the old parser. I'll let @natemoo-re answer tho |
|
I think we're ready to deprecate and remove it. We won't be creating any new releases of this package and the Prettier plugin is almost ready to be moved. |
packages/astro/package.json
Outdated
| "@astrojs/markdown-remark": "workspace:^0.7.0-next.0", | ||
| "@astrojs/prism": "workspace:^0.4.0", | ||
| "@astrojs/webapi": "workspace:^0.11.0", |
There was a problem hiding this comment.
These workspace:* specifiers seemed to have snuck in here...
There was a problem hiding this comment.
I don't know if this was expected, but when I did pnpm install, this happened inside the lockfile:
- '@astrojs/markdown-remark': link:../markdown/remark
- '@astrojs/prism': link:../astro-prism
- '@astrojs/webapi': link:../webapi
+ '@astrojs/markdown-remark': 0.7.0-next.0
+ '@astrojs/prism': 0.4.0
+ '@astrojs/webapi': 0.11.0That's why I added them
There was a problem hiding this comment.
Hmm, I wonder if you did the install from packages/astro rather than the root? Our .npmrc file has the following, which should prevent this.
# Important! Never install `astro` even when new version is in registry
prefer-workspace-packages=true
link-workspace-packages=true
save-workspace-protocol=false # This prevents the examples to have the `workspace:` prefixThere was a problem hiding this comment.
Hmm, I wonder if you did the install from packages/astro rather than the root?
That was the problem. I pushed a fix
* Removed parser from astro * Removed parser files * Updated changeset config * Removed from license
Changes
Removed the deprecated
@astrojs/parser. Also,@astrojs/parsershould be tagged as "deprecated" in NPM.Testing
Docs