Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webapi build script on windows #2830

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix webapi build script on windows #2830

merged 1 commit into from
Mar 18, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 18, 2022

Changes

  • Ran into a problem when debugging with Antony.
  • Fixes pnpm run build on Windows.
  • CI doesn't catch this because the build only runs on Linux and the generated artifacts are shared with Windows.

Testing

Manually

Docs

N/A, bugfix

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

⚠️ No Changeset found

Latest commit: e250bf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthewp
Copy link
Contributor

lgtm

@FredKSchott
Copy link
Member

👍

@natemoo-re natemoo-re merged commit 910cae3 into main Mar 18, 2022
@natemoo-re natemoo-re deleted the fix/windows-build branch March 18, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants