Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod setup improvements #2789

Merged
merged 9 commits into from
Mar 15, 2022

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Mar 14, 2022

Changes

Various Gitpod setup improvements:

  • Install the latest pnpm in workspace
  • Add Astro-build VSCode extension (from open-vsx)
  • Run pnpm run build during prebuild (user doesn't have to wait)
  • Automatically open preview browser when port 3000 is active
  • Run starter demo when workspace starts

Testing

  1. Open this PR in Gitpod - https://gitpod.io/#https://github.com/withastro/astro/pull/2789
  2. pnpm run build should be ready by the time the workspace open (ran during prebuild)
  3. Confirm you can see Astro's starter demo
  4. Open .astro file, and confirm syntax highlighting works

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

⚠️ No Changeset found

Latest commit: 4540cf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sarah11918
Copy link
Member

Open blog example from this PR in Gitpod -
https://gitpod.io/#ASTRO_NEW=blog/https://github.com/withastro/astro/pull/2789

Works on my machine!

Would be nice if we could also configure /src/pages/index.astro to be open (I don't see in Gitpod docs that we can open a particular file, so I don't know if this is possible) only because this opens the entire astro repository. (See screenshot) So, we would need to include instructions re: navigating down through examples>blog to find the relevant files to work on.

Screenshot 2022-03-14 18 44 01

And, here's the syntax highlighting!

Screenshot 2022-03-14 18 46 37

@shaal
Copy link
Contributor Author

shaal commented Mar 15, 2022

@sarah11918 I configured /src/pages/index.astro to open, you can test it with the blog and starter links in the description if this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Thank you so much!

@sarah11918
Copy link
Member

Yup, this is now working for me, opening to a specific page! This is now my screen on start up, after clicking the link to open the basic starter template:

Screenshot 2022-03-15 17 48 52

@natemoo-re natemoo-re merged commit 60fe7bd into withastro:main Mar 15, 2022
@shaal shaal deleted the gitpod--astro-build-vscode-extension branch March 15, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants