Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup the repo, remove outdated files and folders #2771

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

FredKSchott
Copy link
Member

  • Delete old docs/ folder
  • Delete old www/ folder
  • Delete examples/portfolio-svelte after a convo with @tony-navillus, where it felt against Astro's goals of working cross-framework to have a different framework "flavor" for our themes.
  • Delete old netlify.toml file
  • Delete old smoke/ folder
  • See also: chore: removed syntax files #2516

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2022

⚠️ No Changeset found

Latest commit: 38b97d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Mar 12, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to cleanup a tomltuous repo structure 😁

Just checking though: will the Svelte portfolio be moved to a separate repo? Or is it lost to the ages once this is merged? I feel like it's of use to some...

@FredKSchott
Copy link
Member Author

I'd be fine with moving into its own repo! But see note above about having different framework "flavors" of each theme as working against our goal of Astro working well across frameworks.

@FredKSchott FredKSchott merged commit 80066c0 into main Mar 14, 2022
@FredKSchott FredKSchott deleted the cleanup-repo branch March 14, 2022 18:41
@bholmesdev
Copy link
Contributor

@FredKSchott Oh yeah totally agree. Kinda side-eyed the CLI option from npm init astro when I saw it. Like... why is the Svelte portfolio so special? 😉

Anyways, just wanted to be sure we aren't deleting a good example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants