Fix dev resolution of client modules on Windows #2768
Conversation
🦋 Changeset detectedLatest commit: dbd588d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const [, resolvedPath] = await viteServer.moduleGraph.resolveUrl(s); | ||
| return resolvedPath; | ||
| return '/@fs' + prependForwardSlash(resolvedPath); |
There was a problem hiding this comment.
Vite's module graph gives us a broken URL? That's so strange.
There was a problem hiding this comment.
The problem is that there isn't a function in Vite to give a module ID and return a client-compatible pathname. resolveUrl is the closest there is.
There was a problem hiding this comment.
fyi @matthewp and I chatted about this a bit earlier and my integration work might improve this a bit more. The first return value of resolveUrl() is sometimes a more correct URL that we might be able to leverage for windows
* Fix dev resolution of client modules on Windows * Adds a changeset
Changes
astro/client/idle.js./@fswhich is a resolution that Vite understands.Testing
Tested manually in the example apps only :/
Docs
N/A