-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: expose server on local network with new --host flag #2760
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
08898e4
feat: update config to support bool --hostname
bholmesdev c004d55
fix: show localhost for --hostname=true
bholmesdev 4df8154
feat: address logging feature parity w/ Vite
bholmesdev 3579ebe
chore: update type docs
bholmesdev 0b507be
refactor: extract local, network prefs to variable
bholmesdev 06ddb45
feat: add --host to --help output
bholmesdev 76c4bcc
feat: deprecate --hostname, add --host
bholmesdev 2e165f9
feat: add --host tests
bholmesdev 5f2ae80
feat: update preview to support new flags
bholmesdev d153b59
fix: show --host in dev server log
bholmesdev dd14845
feat: update config tests for --host flag
bholmesdev e005346
chore: test lint
bholmesdev d2fbaa1
chore: update lock with new fixture
bholmesdev f5f7c2d
chore: add changeset
bholmesdev 86ac493
refactor: add more details to JSdocs
bholmesdev 4004d6b
fix: update path tests
bholmesdev 6c2554d
feat: only expose when --host is not local
bholmesdev df5d70c
fix: make flag --help less verbose
bholmesdev 30c125c
fix: address @types comments
bholmesdev b1c50d6
fix: lint
bholmesdev 32ad433
chore: remove unused import
bholmesdev e966d3d
fix: use host flag for config test
bholmesdev 6bea3bb
fix: ensure local logs come before network
bholmesdev 0ff49d6
refactor: switch up that network logging one last time!
bholmesdev d21e981
feat: update unit tests
bholmesdev 4ed56cd
chore: remove debugging block
bholmesdev fdf08de
fix: only parse network logs if network is present
bholmesdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: deprecate --hostname, add --host
- Loading branch information
commit 76c4bccb6cc4c088d6e315c75ec15157909c2638
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how should we handle this in the docgen script?
I think my suggestion would be to ignoring it completely, and add a note in the
host
@description
body that it used to be calledhostname
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made that refactor. Waiting for the docgen updates to merge, but will verify my
> blockquote
looks right once those are in 👍