Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML by default #2747

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Escape HTML by default #2747

merged 2 commits into from
Mar 9, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Escapes HTML inside of expressions by default.
  • Remove escapeHTML util. The compiler is no longer using it.

Testing

Planned deprecation, no tests

Docs

Changelog points to docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2022

🦋 Changeset detected

Latest commit: b4e8738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 9, 2022
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the test label Mar 9, 2022
@natemoo-re natemoo-re merged commit 05b66bd into main Mar 9, 2022
@natemoo-re natemoo-re deleted the feat/xss branch March 9, 2022 23:02
This was referenced Mar 9, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* feat: escape HTML by default

* feat(test): add escaping test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants