Feat: show 404 when getStaticPaths doesn't match URL
#2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 951ec46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
reviewed
Mar 9, 2022
Thankfully not! |
bholmesdev
force-pushed
the
feat/get-static-paths-404
branch
from
ea1fcf2
to
07dd78e
Compare
FredKSchott
reviewed
Mar 9, 2022
FredKSchott
reviewed
Mar 9, 2022
natemoo-re
reviewed
Mar 9, 2022
packages/astro/test/fixtures/astro-get-static-paths/src/pages/pizza/[...pizza].astro
Show resolved
Hide resolved
bholmesdev
force-pushed
the
feat/get-static-paths-404
branch
from
935e993
to
de126df
Compare
This reverts commit 9c395a2.
bholmesdev
force-pushed
the
feat/get-static-paths-404
branch
from
ab568fb
to
d6cdb5f
Compare
natemoo-re
approved these changes
Mar 10, 2022
Co-authored-by: Nate Moore <[email protected]>
Co-authored-by: Nate Moore <[email protected]>
|
Since this is the same CI failure that everything is hitting, I'm fine merging this! Go for it. |
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* WIP: return 404 for unmatched getStaticPaths route * feat: regex on static paths to 404 in dev * Revert "WIP: return 404 for unmatched getStaticPaths route" This reverts commit 9c395a2. * feat: call getParamsAndProps pre-ssr to catch errs * fix: remove unused cache regex check * fix: revert getPattern changes * fix: remove unused preload props * fix: log 404 for custom 404 pages * refactor: rename fixture for clarity * feat: add getStaticPaths status code tests * fix: pas rootRelativeUrl to handle subpaths * fix: update dev-routing tests from 500 -> 404 * refactor: make error handling more explicit * lint: use typescript no shadow to fix enum issue * chore: add changeset * refactor: clarify test names * refactor: remove variable reassignment * fix: update dev-routing tests 500 > 404 * refactor: update test file structure * Fix: revert to old logging Co-authored-by: Nate Moore <[email protected]> * Chore: use `const enum` instead Co-authored-by: Nate Moore <[email protected]> * chore: format Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2226
Changes
getPropsAndParamscall from the Vite middlewaregetStaticPathserrors from the browser into the consolepreloadcall into Vite middleware in order to make eagergetPropsAndParamscallno-shadowoption. This is because of random linter issues on enums. See this threadTesting
packages/astro/test/astro-get-static-paths.test.js - assert status codes for valid and invalid static path matches
Docs
N/A