Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed data-astro-raw to is:raw #2706

Merged
merged 2 commits into from
Mar 3, 2022
Merged

chore: changed data-astro-raw to is:raw #2706

merged 2 commits into from
Mar 3, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Mar 3, 2022

Changes

Following the roadmap

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2022

🦋 Changeset detected

Latest commit: 80ff42c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/markdown-remark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels Mar 3, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. ☺️ I'll rerun the test suite to double check the Windows failure.

@JuanM04
Copy link
Contributor Author

JuanM04 commented Mar 3, 2022

I'll rerun the test suite to double check the Windows failure.

That's weird. The tests pass but the process exits with a non-zero. What can that clearTimeout error be related to?

@natemoo-re
Copy link
Member

I'm not sure! Maybe something to do with the Lit tests specifically...

@matthewp
Copy link
Contributor

matthewp commented Mar 3, 2022

I say we remove that test and rely on the lit smoke tests to cover lit support. That test has caused us a lot of pain. I'll open a separate PR.

@JuanM04
Copy link
Contributor Author

JuanM04 commented Mar 3, 2022

These lines from the lit test are causing issues:

after(async () => {
	// The Lit renderer adds browser globals that interfere with other tests, so remove them now.
	const globals = Object.keys(globalThis.window || {});
	globals.splice(globals.indexOf('global'), 1);
	for (let name of globals) {
		delete globalThis[name];
	}
});

@JuanM04
Copy link
Contributor Author

JuanM04 commented Mar 3, 2022

Found the culprit: lit/lit#2510

@matthewp
Copy link
Contributor

matthewp commented Mar 3, 2022

@JuanM04 does that PR fix the issue or cause it?

@JuanM04
Copy link
Contributor Author

JuanM04 commented Mar 3, 2022

That PR fixes the previous issues (causing our botch to break). I'll write my findings in your PR

@matthewp
Copy link
Contributor

matthewp commented Mar 3, 2022

This can be rebased with main now. Thanks for figuring this out @JuanM04 !

@natemoo-re natemoo-re merged commit b2c3738 into withastro:main Mar 3, 2022
@github-actions github-actions bot mentioned this pull request Mar 3, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* chore: changed `data-astro-raw` to `is:raw`

* changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants